feat(issues): Two-column activity icons, colors#115958
Conversation
feedback needed the extra bottom space on the scroll container, not tucked inside the activity section. Also narrows the activity section variant prop to sidebar vs standalone. the drawer can ask for md text size separately, which keeps feedback from needing a fake inline variant. Co-Authored-By: Codex GPT-5 <[email protected]>
The feedback activity work made these components shared, but a bunch of names still said Streamlined and lived under the streamline sidebar folder. Move the shared activity section and compact comment input into neutral homes, and rename the comment actions menu so it says what it is. Co-Authored-By: Codex GPT-5 <[email protected]>
Use the Text primitive for non-note activity messages instead of wiring font-size by hand. keeps the activity section closer to the design system now that it is shared outside the old sidebar. Co-Authored-By: Codex GPT-5 <[email protected]>
Feedback spam activity was falling through the shared issue activity copy and showing up as archived forever. Pass the issue category into the activity formatter so feedback keeps the spam label, with a test covering the regression. Co-Authored-By: Codex GPT-5 <[email protected]>
Adds a FlagPole flag for the updated issue activity row treatment. When enabled, activity rows split actor markers from action icons, color the action icon, and carry that same color onto user avatar rings or system dots. When disabled, the existing one-column activity layout stays in place. Co-Authored-By: Codex GPT-5 <[email protected]>
github-actions
Bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
📊 Type Coverage Diff
🔍 1 new type safety issue introduced
This is informational only and does not block the PR. |
Point the activity row UI at activity-feed-v2 and drop the backend flag registration from this stacked branch. The flag itself now lives in the standalone master PR. Co-Authored-By: Codex GPT-5 <[email protected]>
scttcper
removed
the
Scope: Backend
Make archived activity use the default grey state and move avatar rings to a 2px inset border. Keeps the activity-feed-v2 flag check in place after local testing. Co-Authored-By: Codex GPT-5 <[email protected]>
scttcper
changed the title
scttcper
changed the title
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fde9e8e. Configure here.
| ...defaultConfig, | ||
| icon: theme.tokens.graphics.success.vibrant, | ||
| iconBorder: theme.tokens.border.success.vibrant, | ||
| }; |
There was a problem hiding this comment.
SET_RESOLVED_IN_PULL_REQUEST missing from success color config
Medium Severity
The getActivityColorConfig switch statement includes all SET_RESOLVED_* activity types (SET_RESOLVED, SET_RESOLVED_BY_AGE, SET_RESOLVED_IN_RELEASE, SET_RESOLVED_IN_COMMIT) in the success/green color group — but omits GroupActivityType.SET_RESOLVED_IN_PULL_REQUEST. This means resolved-by-PR activities won't receive the green icon and border that all other resolved activity types get, resulting in an inconsistent visual treatment.
Reviewed by Cursor Bugbot for commit fde9e8e. Configure here.
| const ActivityInputFrame = styled('div')` | ||
| color: ${p => p.theme.tokens.content.primary}; | ||
| `; | ||
|
|
There was a problem hiding this comment.
Sidebar "View more" row misaligned with marker rows
Medium Severity
When the issue-activity-feed-v2 feature flag is enabled, activity items in the sidebar render with a 4-column grid (22px 22px minmax(50px,1fr) auto) via the marker prop, but the "View X more" ActivityTimelineItem doesn't pass a marker, so it gets a 3-column grid. This causes its icon and title to be horizontally misaligned with the activity rows above it — the icon sits where markers are, and the title text shifts left by one column.
Reviewed by Cursor Bugbot for commit fde9e8e. Configure here.
The componentFunction bypass was too broad -- it skipped provider icons for CREATE_ISSUE (GitHub, Jira, etc.) not just the avatar-as-icon for NOTE. Now only NOTE skips componentFunction in two-column layout since its avatar is already in the marker column. Also adds SET_RESOLVED_IN_PULL_REQUEST to the success color group (was missing from the new getActivityColorConfig switch) and passes a marker spacer on the "View more" row so the grid columns align. Co-Authored-By: Claude Opus 4.6 <[email protected]>
3 participants
adds a two column layout based on figma
after